Skip to content

chore: per Ben, add 'GA' to the supported...#2315

Merged
Gerry-Forde merged 5 commits into
release-1.10from
add-ga-label
Jun 8, 2026
Merged

chore: per Ben, add 'GA' to the supported...#2315
Gerry-Forde merged 5 commits into
release-1.10from
add-ga-label

Conversation

@nickboldt

Copy link
Copy Markdown
Member

What does this PR do?

chore: per Ben, add 'GA' to the supported plugins page title

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt

Copy link
Copy Markdown
Member Author

/cherry-pick main

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhdh-bot

rhdh-bot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

PR Build Results

Build passed -- 35/35 titles | 81s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2315/


Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.


Updated 2026-06-08 09:56:34 UTC

@benwilcock

Copy link
Copy Markdown

/lgtm

Comment thread modules/extend_dynamic-plugins-reference/ref-ga-supported-plugins.adoc Outdated
@openshift-ci openshift-ci Bot removed the lgtm label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@Gerry-Forde Gerry-Forde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough update but the original PR broke a CQA validation check - when the title changed the ID and filename must match according to CQA-10. I updated the PR, so all looks good now.

nickboldt and others added 2 commits June 5, 2026 16:15
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Update file ID and filename to match the new title "GA supported plugins" for CQA-10 compliance.

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

@kim-tsao kim-tsao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to use the term "Generally Available" instead of GA. I'll update this PR

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@rhdh-bot

rhdh-bot commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Shellcheck Analysis Results

Changed shell scripts in this PR: 1

Scripts analyzed:

  • modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh

Check the Files changed tab for detailed shellcheck suggestions.

All findings are reported as warnings and won't block the PR.


Automated shellcheck analysis • See shellcheck.net for details

@kim-tsao

kim-tsao commented Jun 5, 2026

Copy link
Copy Markdown
Member

@Gerry-Forde @nickboldt, I made the following changes:

  • added a new :generally-available: attribute that is now used by the template and generated adoc
  • removed supported from the docs titles. I think support is now implied with the term Generally Available
  • updated the table generation script to pick up the modified doc names

Can you please re-review?

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@Gerry-Forde Gerry-Forde merged commit 4d1babd into release-1.10 Jun 8, 2026
9 checks passed
@Gerry-Forde Gerry-Forde deleted the add-ga-label branch June 8, 2026 12:30
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@nickboldt: new pull request created: #2335

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants